[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #11183 [meek]: Make an HTTP requestor Firefox extension for meek-client
#11183: Make an HTTP requestor Firefox extension for meek-client
-------------------------+--------------------
Reporter: dcf | Owner: dcf
Type: project | Status: closed
Priority: normal | Milestone:
Component: meek | Version:
Resolution: fixed | Keywords: meek
Actual Points: | Parent ID: #10935
Points: |
-------------------------+--------------------
Comment (by gk):
Review of https://gitweb.torproject.org/pluggable-
transports/meek.git/blob/HEAD:/firefox/component/main.js part 1
{{{
4 // The extension opens a TCP socket listening on localhost (port 7000).
}}}
See previous comment: you seem to advocate hard-coding a listener port,
no?
{{{
50 Components.interfaces.nsIServerSocketListener,
}}}
Nit: there is no "," needed here as this is the last interfaces listed.
{{{
56 return
}}}
Nit: a ";" is missing at the end.
{{{
124 this.requestreader = null;
}}}
Nit: should be "this.requestReader = null;" see line 131 as well.
{{{
130 readRequest: function(callback) {
}}}
Seems you can omit the |callback|, no? You are not using it in the
readRequest method. Or did you plan to pass it to the RequestReader
constructor?
I have to think a bit about your usage of nsISocketTransport and whether
you are affected by the things we run in #9531. See the comments there
(e.g. regarding OPEN_BLOCKING|OPEN_UNBUFFERED)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11183#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs