[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #11633 [Tor]: Quench a few warnings found with gcc-4.2 and clang

#11633: Quench a few warnings found with gcc-4.2 and clang
------------------------+--------------------------------
     Reporter:  _x3j11  |      Owner:
         Type:  defect  |     Status:  needs_revision
     Priority:  normal  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-client build
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by nickm):

 Replying to [comment:2 _x3j11]:
 > I will have a think about the best way to address the NetBSD case (the
 second patch needs fixing anyway as it wasn't split correctly).

 So, most of the time_t patch is casting timeval.tv_sec to time_t before
 passing it to something that needs a time_t.  That doesn't need a change.

 For the 'add' cases, one option is to change the interval types to 'int'.
 We require that int be at least 32 bits, and I don't think we need any
 >68-year expiry times.  But that might be a big patch; I'm not sure.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11633#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs