[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #3242 [Website]: Research moving the website from svn to git
#3242: Research moving the website from svn to git
-------------------------+-----------------------------
Reporter: phobos | Owner: phobos
Type: defect | Status: reopened
Priority: normal | Milestone: Tor Website 3.0
Component: Website | Version:
Resolution: | Keywords: www-team
Actual Points: | Parent ID:
Points: |
-------------------------+-----------------------------
Comment (by mrphs):
We talked about autobuilds and ways to avoid disaster, on `#tor-project`
yesterday. There were two slightly different suggestions:
{{{
< phobos> git vs. svn is arguable, but not worth arguing over
03:22 < mrphs> I remember weasel mentioned you didn't like automatic
builds? and that was what stopped him from moving forward?
03:22 < mrphs> I might be wrong tho.
03:23 < arma81> mrphs: correct. it's really elegant to just have the
webserver build itself after commit. easy to do. but,
03:23 < arma81> what if somebody commits an rm -rf / ?
03:23 < phobos> automatic builds are fine
03:23 < phobos> automatic pushes to live are not fine
03:23 < arma81> i guess the answer is, don't let people merge bad stuff.
03:23 < arma81> phobos: if there's a website master git and only a few
people can push to it, automatic builds of that sound fine to me.
03:24 < mrphs> +1 ^
03:24 < arma81> trouble is.. who are those people? you me helix mike?
03:24 < phobos> the idea is to have a staging site
03:24 < phobos> so commits to go staging
03:24 < phobos> and then some small list of people push to live
03:24 < arma81> well, that's one idea. it's not very gitty.
03:26 < phobos> the code repo and process to go live are seperate things
03:28 < mrphs> why does it have to be any different from other projects?
every project has a maintainer, every random person can commit, submit a
patch and it can be merged after review by its maintaner(s).
03:29 < phobos> we're saying the same thing
03:30 < phobos> anyone can commit/patch
03:30 < phobos> it autobuilds to staging
03:30 < phobos> then a webmaster commits to live
03:30 < phobos> or pushes to live
03:31 < mrphs> it's two (slightly) different ways to do the same thing.
yes.
03:31 < phobos> this avoids someone slipping in ads, subtle changes to
text and having it go live
03:32 < phobos> or missing brackets
03:32 < phobos> etc
03:33 < phobos> but really, this discussion should be in the ticket
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3242#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs