Re: [tor-bugs] #15652 [Tor]: Base64 code cleanups.

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#15652: Base64 code cleanups.
-----------------------------+--------------------------------
     Reporter:  yawning      |      Owner:  yawning
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor          |    Version:  Tor: unspecified
   Resolution:               |   Keywords:  tor-core
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------

Comment (by yawning):

 Replying to [comment:2 nickm]:
 > e58d27f186ec5a8f67b4aee4513c3e02ff7f29b9
 >   * I think that ENCODE_OPENSSL is maybe not so great a name.  Maybe
 ENCODE_MULTILINE?

 1100a83ce45d1872be8333bea1a1e55dd318dfe7

 >   * Style says to wrap macros in `do { ... } while (0)`.  Harmless in
 this case.

 0b8bb8988f380bf2c9c3ffc3b21c7457db239813

 >   * I wonder whether it's better to have the new behavior in a new
 function, so that less of the code needs to change.  But I'd say that it's
 our call in this case though.

 If anything I would be tempted to put the old behavior in a function that
 explicitly adds multiline output since that's a PEM-ism (and OpenSSL's PEM
 output flavor as well).  I think what's in the branch is clear enough
 though.

 I amended a commit so I can give the autosquash thing a whirl, you might
 need to re-pull. (There's also one more commit past what you've seen that
 fixes up a doxygen comment).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15652#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs