[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #14847 [Tor]: Controller: add a command to fetch HS descriptor from HSdir(s)

#14847: Controller: add a command to fetch HS descriptor from HSdir(s)
-------------------------+-------------------------------------------------
     Reporter:  dgoulet  |      Owner:  dgoulet
         Type:           |     Status:  needs_review
  enhancement            |  Milestone:  Tor: 0.2.7.x-final
     Priority:  normal   |    Version:  Tor: 0.2.7
    Component:  Tor      |   Keywords:  SponsorR, tor-hs, controller,
   Resolution:           |  nickm-review, 027-triaged-1-in, SponsorS
Actual Points:           |  Parent ID:  #3521
       Points:  small-   |
  remaning               |
-------------------------+-------------------------------------------------

Comment (by dgoulet):

 New branch! :) Although, I had to squash commits and make a "Multiple
 fixes" commit. Too many conflicts with the current master while rebasing
 and thus this makes it simpler I think.

 > * It would be pretty cool if the command parsing part of command handler
 were split into a separate function.

 Hrm so currently HSFETCH has basic command parsing and I feel like we
 should try to split control.c into smaller files at some point and have a
 file with common parsing functions. The control C file is already at 5508
 lines and pretty sure lots of duplicate! Also, if we do a refactoring, we
 could use your control parsing branch also?

 In the meantime here is the branch with the fixes except the above.

 See: `bug14847_027_06`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14847#comment:42>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs