[tor-bugs] #15824 [Tor]: Silly ambiguous function names in rendservices

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#15824: Silly ambiguous function names in rendservices
---------------------+---------------------
 Reporter:  special  |          Owner:
     Type:  defect   |         Status:  new
 Priority:  trivial  |      Milestone:
Component:  Tor      |        Version:
 Keywords:  tor-hs   |  Actual Points:
Parent ID:           |         Points:
---------------------+---------------------
 rendservices.c has two functions:

 rend_services_introduce
 rend_service_introduce

 One of these is called every second to consider adding new intro points to
 our services. The other one is called to handle an inbound INTRODUCE2 cell
 for a service.

 I suggest renaming them to something like:

 rend_consider_services_intro_points
 rend_service_receive_introduction

 Also worth noting that rend_service_validate_intro_early does nothing (/*
 TODO */).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15824>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs