[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17435 [Tor]: Patch dir-spec with the shared randomness info
#17435: Patch dir-spec with the shared randomness info
------------------------------+------------------------------------
Reporter: asn | Owner: asn
Type: defect | Status: needs_review
Priority: Medium | Milestone: Tor: 0.2.9.x-final
Component: Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-spec, tor-hs | Actual Points:
Parent ID: #16943 | Points: small
Reviewer: | Sponsor: SponsorR-can
------------------------------+------------------------------------
Changes (by asn):
* status: needs_revision => needs_review
Comment:
Replying to [comment:6 atagar]:
> Looks good to me, thanks asn! When this becomes live please shoot me an
example of these in actual descriptors (for unit tests) and I'd be happy
to add it to Stem.
>
> Just a couple minor nitpicks left...
>
> > AlgName ::= Any number of ASCII characters
>
> I suspect this can be pinned down a bit more. How about the following?
>
> AlgName ::= 1*(ALPHA / DIGIT / "_" / "-")
>
> > Identity ::= 40 hexadecimal characters ([A-Fa-f0-9])
>
> Actually, if you want to use 'Fingerprint' that's already defined...
>
> https://gitweb.torproject.org/torspec.git/tree/control-spec.txt#n206
I addressed both issues you raised above and pushed a fixup commit in my
`prop250_dirspec`.
(FWIW, we don't actually use the dollar sign in fingerprints, so I didn't
put it there.)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17435#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs