[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18931 [Metrics/CollecTor]: coding style polishing

#18931: coding style polishing
-------------------------------+------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  task               |         Status:  needs_review
 Priority:  Medium             |      Milestone:
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  ctip               |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+------------------------------
Changes (by karsten):

 * status:  new => needs_review


Comment:

 There, I handled 2/3 of checkstyle warnings that were easy to handle,
 including your wishlist items 1 and 2.  I did not handle anything related
 to Javadoc (your item 3), variable names, or distance between declaration
 and usage.  Please take a look at [https://gitweb.torproject.org/karsten
 /metrics-db.git/log/?h=task-18931 my branch task-18931], also at the
 change to the checkstyle file.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18931#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs