[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24854 [Core Tor/Tor]: Extract the authority list from config.c

#24854: Extract the authority list from config.c
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  torspec, tor-dirauth, 029-backport,  |  Actual Points:
  031-backport, 032-backport, review-group-32,   |
  review-group-33, review-group-34,              |
  034-triage-20180328                            |
Parent ID:  #24818                               |         Points:  0.2
 Reviewer:  ahf                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by ahf):

 Hey beastr0,

 Thanks for your patches. I think they look good, but it's not possible for
 us to integrate them right now in the current form as we need them in a
 Git patch format. I can do this for you if you want me to.

 Otherwise you can do this yourself as it will make the life of the patch
 reviewers much easier: create a branch in Git with your changes in, do a
 `git add <file>` for each `<file>` you have modified, then do `git commit`
 and write a commit message. For Tor we normally also want a 'changes' file
 that describes the change for use in ChangeLog messages when we make the
 release. Once this is done you can push your branch to, for example,
 Github and post a link here for where we can review it :-)

 We have some documentation on this process here:
 https://gitweb.torproject.org/tor.git/tree/doc/HACKING/GettingStarted.md

 Unless I hear back from you, I will proceed with turning your changes into
 a Git style patch and credit you as beastro0 in the ChangeLog entry!

 Thanks

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24854#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs