[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #22029 [Core Tor/Tor]: Allow ed25519 keys to be banned in the approved-routers file
#22029: Allow ed25519 keys to be banned in the approved-routers file
-------------------------------------------------+-------------------------
Reporter: teor | Owner: neel
Type: enhancement | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.4.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: 034-triage-20180328, | Actual Points:
034-removed-20180328 |
Parent ID: | Points: 1
Reviewer: asn | Sponsor:
-------------------------------------------------+-------------------------
Changes (by asn):
* status: needs_review => needs_revision
Comment:
I'm so sorry but in my previous message I meant for you to squash the
`squash!` commits and the commits that edit other commits (like
`d44ff1c`). And also to properly decouple the `f7b5e4c` test-related
changes from behavior-related changes. Sorry for the confusion and for not
clarifying properly.
I think this is a complex enough change that I wouldn't want it to merge
as a single commit. Can you please chop-up your latest PR into separate
commits to make it more clear why all these changes are necessary to
achieve the final result? Also perhaps split code-commits from test-
commits.
Thanks and sorry for the confusion again.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22029#comment:40>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs