[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29732 [Core Tor/Tor]: Add full-fledged deterministic PRNG support for testing.

#29732: Add full-fledged deterministic PRNG support for testing.
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  enhancement   |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  1
Parent ID:                |         Points:
 Reviewer:  ahf           |        Sponsor:
--------------------------+------------------------------------
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 I think this code looks good and can be merged. I've been focusing on
 checking to ensure that the API cannot be used wrongly in a non-testing
 setup and it seems like the important functions here are all protected
 using the `TOR_UNIT_TESTS` guard. If the reseeding mechanism, outside of
 the unit test setup, is disabled, Tor will crash with an unreached
 assertion in "production", which is what we want I think.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29732#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs