[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30069 [Applications/Tor Browser]: Security slider and about:tor strings are untranslated in Tor Browser for Android

#30069: Security slider and about:tor strings are untranslated in Tor Browser for
Android
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-8.5-must,            |  Actual Points:
  TorBrowserTeam201904, GeorgKoppen201904, tbb-  |
  parity                                         |
Parent ID:  #26782                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 Replying to [comment:2 sysrqb]:
 > I think this is a problem with Chrome localization, in general.
 `about:firefox` isn't localized, as well. I compared this with the current
 version of Fennec (`66.0.2`) and `about:firefox` shows localized text.

 s/Chrome/system content/ maybe? In any case, not chrome. I tested this a
 little more, and `about:firefox` is localized, but it seems I needed to
 restart the app before it took affect (the app doesn't correctly adjust
 its strings after changing the system locale configuration while running).
 Unfortunately, `about:tor` and torbutton's `Security Settings` aren't
 localized.

 It looks like we're missing the DTD declaration. `about:firefox` (in
 `mobile/android/chrome/content/about.xhtml`) use this for declaring the
 DTD it should use.
 {{{
 <!DOCTYPE html [
 [snip]
 <!ENTITY % fennecDTD SYSTEM "chrome://browser/locale/about.dtd">
 %fennecDTD;
 ]>
 }}}

 where `chrome://browser/locale/about.dtd` is `mobile/android/locales/en-
 US/chrome/about.dtd`. This is documented [https://developer.mozilla.org
 /en-US/docs/Mozilla/Tech/XUL/Using_multiple_DTDs here]. This should be an
 easy fix :) ha.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30069#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs