[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32088 [Core Tor/Tor]: Proposal 310 - choose guards in sampled order

#32088: Proposal 310 - choose guards in sampled order
--------------------------------------+------------------------------------
 Reporter:  Jaym                      |          Owner:  (none)
     Type:  enhancement               |         Status:  needs_revision
 Priority:  High                      |      Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor              |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tor-spec prop271 prop310  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:  nickm                     |        Sponsor:
--------------------------------------+------------------------------------
Changes (by nickm):

 * priority:  Medium => High
 * status:  needs_review => needs_revision


Comment:

 Hi!  Initial notes here.  Sorry for the delay in the review.

 First thing is, continuous integration isn't passing. It looks like there
 might be a memory leak in the unit tests?  You can test that yourself by
 building with --enable-fragile-hardening and running the tests.

 Also there seems to be a practracker failure:
 {{{
 problem file-size /src/feature/client/entrynodes.h 652
 }}}
 You can suppress this warning by editing the
 scripts/maint/practracker/exceptions.txt file and increasing the number on
 that line.

 The code itself looks well-written and straightforward.  I have some
 suggestions for perhaps making it more robust; I have left them on the
 github request.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32088#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs