[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33675 [Core Tor/Chutney]: Search microdescriptor files for relay ed25519 keys
#33675: Search microdescriptor files for relay ed25519 keys
-------------------------------------------+-------------------------------
Reporter: teor | Owner: anuradha1904
Type: enhancement | Status:
| needs_revision
Priority: Medium | Milestone:
Component: Core Tor/Chutney | Version:
Severity: Normal | Resolution:
Keywords: ipv6, prop311, outreachy-ipv6 | Actual Points: 0.2
Parent ID: #33428 | Points: 0.5
Reviewer: teor | Sponsor: Sponsor55-can
-------------------------------------------+-------------------------------
Comment (by teor):
Hi, you've told me that the changes are working in this PR:
https://github.com/torproject/chutney/pull/65
You also asked what the problem with the old code was:
* `_setEd25519Id()` was only called when the keys were created, during
`chutney configure`
* so `_env['ed25519_id']` was only set during `chutney configure`
* but `getNodeDirInfoStatusPattern()` is only called during `chutney
wait_for_bootstrap`, which runs in a different python process
* so when `getNodeDirInfoStatusPattern()` looked for `_env['ed25519_id']`,
it was not set
The solution was to move `_setEd25519Id()` to `LocalNodeController`, so we
could call it during `chutney wait_for_bootstrap`.
I will leave a detailed review on the pull request.
Please use this ticket to communicate - we don't seem to be on IRC at the
same time.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33675#comment:30>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs