[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #1820 [Tor - Relay]: make distcheck fails for --disable-asciidoc
#1820: make distcheck fails for --disable-asciidoc
-------------------------+--------------------------------------------------
Reporter: ln5 | Owner: ln5
Type: defect | Status: new
Priority: trivial | Milestone:
Component: Tor - Relay | Version:
Keywords: | Parent:
-------------------------+--------------------------------------------------
Comment(by nickm):
An interesting issue. From a certain point of view, --disable-asciidoc
doesn't make any sense for use with "make distcheck", since without
asciidoc you _can't_ in fact generate the .1.in files that need to go in a
proper Tor source distribution, so it's no surprise when a later attempt
to build that distribution fails.
But of course, "make distcheck" isn't just for checking if you can make a
good distribution vis-a-vis documentation; it's also good for checking
lots of other build issues, and it would be neat if it mostly worked
without asciidoc.
To fix the immediate issue here, all we have to do is make the .1.txt
files go into EXTRA_DIST whether USE_ASCIIDOC is true or not. But make
distcheck with --disable-asciidoc will still fail, since the .1.in files
won't exist in the distribution, and the test build won't know to use
--disable-asciidoc
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1820#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs