[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2930 [Tor Relay]: Overwrite files in stats/ directory rather than appending to them

#2930: Overwrite files in stats/ directory rather than appending to them
-------------------------+--------------------------------------------------
 Reporter:  karsten      |          Owner:                    
     Type:  enhancement  |         Status:  new               
 Priority:  normal       |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay    |        Version:                    
 Keywords:               |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------

Comment(by karsten):

 I was wondering about making separate patches, but I didn't find a clear
 point to do this separation.  The current code is not easy to test,
 because it relies on (a) the file system and (b) the global list of
 circuits.  The patch for #2930 solved (a), but I wanted to test it and
 therefore had to implement (b), too.  On the other hand, I couldn't
 implement (b) without implementing (a), or I wouldn't be able to write
 useful tests for that code, either.  Of course, I can now make a separate
 patch for the changes for (a) without the tests and a second patch with
 all the tests in a separate patch.  That's not how the code was written,
 but it may be easier to review.  Do you prefer that?  (I also ask, because
 I have more patches for this ticket that I'd write similarly.)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2930#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs