[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #1692 [Tor Relay]: No Events for SETCONF

#1692: No Events for SETCONF
-------------------------+--------------------------------------------------
 Reporter:  atagar       |          Owner:  krkhan            
     Type:  enhancement  |         Status:  assigned          
 Priority:  normal       |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay    |        Version:                    
 Keywords:               |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------
Changes (by krkhan):

  * status:  needs_review => assigned


Comment:

 *
 [https://github.com/krkhan/tor/commit/1f734322b1867620ce9e93f9fad112918089198a
 Commit]: (Cherrypicked) Add smartlist_[v]asprintf_add
  *
 [https://github.com/krkhan/tor/commit/5e2123290003851addda02ce59e2dbb4a28efe4d
 Commit]: fixup! Add smartlist_[v]asprintf_add
  *
 [https://github.com/krkhan/tor/commit/802e79a4f18bb0322108e43e972b28a9ea86ad55
 Commit]: Use smartlist_asprintf_add() to improve readability.
  *
 [https://github.com/krkhan/tor/commit/d111b06c9219924e63f0c4ed2b2a429d054ac2fc
 Commit]: Escape configuration values before sending them via CONF_CHANGED.
  *
 [https://github.com/krkhan/tor/commit/7bf046ca9f7323505b551b4115cf2d26491bce12
 Commit]: Return if CONF_CHANGED isn't interesting.
  * '''[https://github.com/krkhan/tor/compare/bug1692 Tor patch]''':
 Complete patch

 > Also, please move the code that constructs a key-value list into
 > control_event_conf_changed -- that function should take as its
 > arguments the old and new or_options_t structures, and only make
 > a list of the options that changed if some control-port client
 > actually wants a CONF_CHANGED event.

  * Comparison of options is dependent on {{{option_is_same()}}} and
 {{{get_assigned_option()}}}.
  * {{{option_is_same()}}} and {{{get_assigned_option()}}} require an
 argument of type {{{const config_format_t *}}}.
  * {{{config_format_t}}} is defined inside config.c, it needs to be
 defined in config.h along with other structs it's dependent on in order to
 be accessible from control.c

 I have refactored the code to make this work but since this generated a
 mammoth changeset, I have created a separate branch for this:

  *
 [https://github.com/krkhan/tor/commit/4581b27a67c8999e47457363cc73e1bd1bf012ab
 Commit]
  * [https://github.com/krkhan/tor/compare/bug1692-refactored Alternate Tor
 patch]

 Please let me know if I should continue with the refactored branch
 ([https://github.com/krkhan/tor/tree/bug1692-refactored
 bug1692-refactored]) or the original branch
 ([https://github.com/krkhan/tor/tree/bug1692 bug1692]).

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1692#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs