[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #1692 [Tor Relay]: No Events for SETCONF
#1692: No Events for SETCONF
-------------------------+--------------------------------------------------
Reporter: atagar | Owner: krkhan
Type: enhancement | Status: assigned
Priority: normal | Milestone: Tor: 0.2.3.x-final
Component: Tor Relay | Version:
Keywords: | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Comment(by nickm):
I think that the original branch looks closer to the right approach: just
like formatting controller stuff belongs in control.c, picking apart the
various pieces of or_options_t belongs on config.c. Anything that moves
the various config_var_t and friends out of config.c and makes them
publicly visible is IMO a total nonstarter inasmuch as it makes the code
less modular, not more.
Personally, I think we should just get to a point where we can merge
bug1692, and only then consider big refactorings.
To that end, one question about 7bf046ca9f7: should the && in the first
test be an || ?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1692#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs