Re: [tor-bugs] #3679 [Torctl]: TorCtl Event Parsing Rewrite

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#3679: TorCtl Event Parsing Rewrite
-------------------------+--------------------------------------------------
 Reporter:  atagar       |          Owner:              
     Type:  enhancement  |         Status:  needs_review
 Priority:  normal       |      Milestone:              
Component:  Torctl       |        Version:              
 Keywords:               |         Parent:              
   Points:               |   Actualpoints:              
-------------------------+--------------------------------------------------

Comment(by robinson):

 This is a good change that will make adding new events (e.g.
 STATUS_CLIENT) easier in the future.  I am using this event parsing model
 in testing with my client and it works as well as the old model.  (It
 feels faster to me, also, but I have no numbers to back that up.)

 The only change I would make would be to chop up the commits differently,
 but that is more of a style issue.  As an example,
 https://gitweb.torproject.org/atagar/pytorctl.git/commit/a6a23766d2a6be88e0742e5f92b20e1ecfdedf5d
 includes the addition of KW_ARG and _decodeFields() as well as changes to
 the Event and StatusEvent classes.  I would split these out into 2 or 3
 commits.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3679#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs