Re: [tor-bugs] #3724 [Torctl]: Support CONF_CHANGED events

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#3724: Support CONF_CHANGED events
-------------------------+--------------------------------------------------
 Reporter:  krkhan       |          Owner:  krkhan            
     Type:  enhancement  |         Status:  needs_review      
 Priority:  normal       |      Milestone:  Tor: 0.2.3.x-final
Component:  Torctl       |        Version:                    
 Keywords:               |         Parent:  #1692             
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------

Comment(by krkhan):

 Replying to [comment:2 robinson]:
 > Where is the specification for CONF_CHANGED events?  I don't see it in
 control-spec.txt.

 CONF_CHANGED events were committed to the git repo (patch from #1697).
 Section 4.1.17 of control-spec.txt explain the event.

 > Would this be the first multi-line event handled by TorCtl?  Otherwise,
 why the additions to _handle1()?  Why should multi-line events be handled
 this way (e.g. set(codes)), rather than each line separately?

 Yes, it is indeed the first multi-line event handled by TorCtl. set(codes)
 merely ensures that all lines belonging to the multi-line event have the
 same code. Individual lines are parsed after that.

 > I recommend this be implemented under Daemon's rewrite of the event
 handler in ticket #3679.

 Damian shall be able to make a better judgment on whether multi-line event
 parsing should be included in #3679's fix.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3724#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs