[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #2046 [Tor Client]: Port Tor code for starting a background process to Windows
#2046: Port Tor code for starting a background process to Windows
------------------------+---------------------------------------------------
Reporter: sjmurdoch | Owner: sjmurdoch
Type: task | Status: needs_review
Priority: major | Milestone: Tor: 0.2.3.x-final
Component: Tor Client | Version:
Keywords: | Parent: #1983
Points: | Actualpoints:
------------------------+---------------------------------------------------
Comment(by nickm):
Looks good; merging!
Minor issue we should fix:
* I think the need_quotes check in format_commandline_argument might be
inadequate: Shouldn't it also check for \ and " ?
Thing we could fix later:
* In format_commandline_argument(), it would be neat to skip the business
of building a smartlist of char*, and just pre-allocate a guaranteed-to-
be-long-enough string -- I think that strlen(arg)*2 + 3 would be long
enough, since each character in the input turns into at most 2 characters
in the output, and there are at most 3 characters of overhead: 1 for the
nul-terminator, 2 for quotes.
Let me know if you'd like me to open tickets for those.
Stuff I tweaked:
* I think the tor_join_cmdline() function and
format_commandline_argument() functions ought to have "win" somewhere in
their names. (Fixed this.)
* In documentation for tor_split_lines, we should refer to a NUL
character. NULL is a pointer. (Pedantically, NUL is a null character,
and null-terminated strings are also NUL-terminated, but never NULL-
terminated.) (Fixed this.)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2046#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs