[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #6364 [Tor Client]: Make sure the NETINFO cells include and use IPv6 addresses correctly

#6364: Make sure the NETINFO cells include and use IPv6 addresses correctly
-----------------------------------+----------------------------------------
 Reporter:  ln5                    |          Owner:  ln5         
     Type:  enhancement            |         Status:  needs_review
 Priority:  normal                 |      Milestone:              
Component:  Tor Client             |        Version:              
 Keywords:  SponsorG20120930 ipv6  |         Parent:  #4564       
   Points:                         |   Actualpoints:              
-----------------------------------+----------------------------------------

Comment(by nickm):

 Replying to [comment:6 ln5]:
 > Replying to [comment:5 nickm]:
 > > Looks ok. Shall I merge?
 > >
 > > Is there a separate ticket for using NETINFO cells correctly? If so,
 the code in the NETINFO that fetches my_appent_addr is IPv4-only.  (On the
 other hand, my_apparent_addr just isn't used.)
 >
 > There isn't, as far as i know. This branch is supposed to do that too.
 >
 > Right, I looked at this line in tor-spec.txt and just let it be as it
 > was: "[As of 0.2.3.1-alpha, nodes use neither of these values.]"
 >
 > Want me to either remove the IPv4 address fetching, add IPv6 fetching
 > or just keep ignoring it? Happy to do it either way.

 Either add IPv6 fetch; remove IPv4 fetch, or add a comment to the IPv4
 fetch saying that it's broken to be IPv4-only and we need to fix that if
 we ever start using the info.

 > > When you talk about printing both addresses, do you mean in
 command_process_netinfo_cell() or somewhere else?
 >
 > I mean in command_process_netinfo_cell().

 So, the only one we log is conn->_base.address, which I *think* is the one
 that means the "real" address of this router, yeah?  If so that's ok.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6364#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs