[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #9462 [BridgeDB]: BridgeDB does some strange things when parsing bridge descriptors
#9462: BridgeDB does some strange things when parsing bridge descriptors
-------------------------+--------------------------------------------------
Reporter: isis | Owner: isis
Type: defect | Status: accepted
Priority: normal | Milestone:
Component: BridgeDB | Version:
Keywords: descriptors | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Comment(by isis):
Replying to [comment:3 asn]:
> fwiw the keyid thing is an artifact of proposal 180:
> https://gitweb.torproject.org/torspec.git/blob/HEAD:/proposals/180
-pluggable-transport.txt
>
> I don't think the parsing of 'keyid' was ever implemented in tor.git.
Thanks, I missed that. I was looking in dir-spec, not pt-spec or any of
the proposals.
Hmm. With the `keyid=[fingerprint]` part of proposal 180-pluggable-
transport, if it were to be implemented, then BridgeDB would have to do
all of the awkward things, wherein it searches for the string `'keyid='`
if the bridge is a PT, and search for the fingerprint positionally
otherwise. That will start to get messy.
I think that the `[arglist]` format (iirc introduced in 180 also, but it's
at least in dir-spec), is a good idea, but perhaps only if the descriptors
for vanilla bridges and relays report their fingerprints in this manner as
well.
I'm still taking it out for now, until we have descriptors that use
`'keyid='`.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9462#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs