[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5609 [Tor]: Bridges should announce transport listening addresses to the control port

#5609: Bridges should announce transport listening addresses to the control port
---------------------------+------------------------------------------------
 Reporter:  asn            |          Owner:                    
     Type:  defect         |         Status:  needs_revision    
 Priority:  normal         |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor            |        Version:                    
 Keywords:  pt tor-bridge  |         Parent:                    
   Points:                 |   Actualpoints:                    
---------------------------+------------------------------------------------
Changes (by nickm):

  * status:  needs_review => needs_revision


Comment:

 event_mask_t is uint32_t.

 This patch adds an event "#define EVENT_TRANSPORT_LAUNCHED 0x20".  But
 that doesn't fit in uint32_t.

 This makes me wonder whether this patch was actually ever tested. How
 could that have worked?

 I'll widen that mask and add some unit tests.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5609#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs