[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12684 [Firefox Patch Issues]: Make "Not Now" the default button for TorBrowser's canvas permission dialogue

#12684: Make "Not Now" the default button for TorBrowser's canvas permission
dialogue
-------------------------------------+-------------------------------------
     Reporter:  isis                 |      Owner:  mikeperry
         Type:  defect               |     Status:  needs_review
     Priority:  critical             |  Milestone:
    Component:  Firefox Patch        |    Version:
  Issues                             |   Keywords:  tbb-usability, tbb-
   Resolution:                       |  linkability, MikePerry201407R,
Actual Points:                       |  TorBrowserTeam201407
       Points:                       |  Parent ID:
-------------------------------------+-------------------------------------

Comment (by gk):

 Replying to [comment:15 isis]:
 > Replying to [comment:14 gk]:
 > > Looks good to me. Thanks isis! The only thing I am a bit unhappy with
 is that you now have the "Not now" option twice available if the drop down
 menu is open. That might be confusing to some users ("Why is there an
 additional 'Not now' and what is it doing compared to the already selected
 one?"). But I am happy if that is handled in a different bug if that is
 bothering users at all...
 >
 > Thanks! But... ''le sigh.''
 >
 > I couldn't figure out the `PopupNotification.jsm` API very well... I was
 never able to determine where the default Mozilla `[x] Not now` array item
 was coming from, nor how to disable/change it.
 >
 > I'd prefer to just do it right, and not substitute one confusing UI for
 a slightly-less-confusing UI. Do you know where the default
 `secondaryActions` array item comes from, gk?

 That is not part of the `secondaryActions` array. It is rather "hard-
 coded" in the popup-notification XBL binding, I think:
 https://mxr.mozilla.org/mozilla-
 esr24/source/toolkit/content/widgets/notification.xml#477

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12684#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs