[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12866 [Onionoo]: cycle between util and docs packages

#12866: cycle between util and docs packages
-------------------------+--------------------------
     Reporter:  iwakeh   |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:
    Component:  Onionoo  |    Version:
   Resolution:           |   Keywords:
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------

Comment (by karsten):

 Agreed that SimpleDateFormat could be made a static field.  I'm just
 careful, because I've been bitten by that class not being thread-safe.
 That shouldn't be a problem here.  However, whether we're instantiating
 two SimpleDateFormats every hour or re-using a static one doesn't make
 much of a difference.

 Will do another review, run some tests, and then merge and deploy.  That's
 going to take a while though.  (Will also reply to #12869 later on that
 ticket.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12866#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs