Re: [tor-bugs] #12606 [Pluggable transport]: Refactor obfs4proxy (and the support protocol code)

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#12606: Refactor obfs4proxy (and the support protocol code)
-------------------------------------+---------------------
     Reporter:  yawning              |      Owner:  yawning
         Type:  defect               |     Status:  new
     Priority:  normal               |  Milestone:
    Component:  Pluggable transport  |    Version:
   Resolution:                       |   Keywords:  obfs4
Actual Points:                       |  Parent ID:  #12130
       Points:                       |
-------------------------------------+---------------------

Comment (by asn):

 Code looks good. Couldn't find any obvious issues.

 Some notes:
 - It would be nice if `findMarkMac()` had a unittest.
 - You might want to consider stealing the integration tester of obfsproxy,
 even if it's just for your own testing. It has really helped over the
 years to find some dump code changes that break transports.
 - In `serverSetup()` maybe you want to `continue` in:
 {{{
                 ln, err := net.ListenTCP("tcp", bindaddr.Addr)
                 if err != nil {
                         pt.SmethodError(name, err.Error())
                 }
 }}}
 - Maybe you want to add a link to obfs2/obfs3 specs?
 - Installation instructions are needed.
 - Maybe now is a good time to establish a ChangeLog too?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12606#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs