[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12882 [Onionoo]: Logging Framework

#12882: Logging Framework
-----------------------------+--------------------------
     Reporter:  iwakeh       |      Owner:  iwakeh
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Onionoo      |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------
Changes (by iwakeh):

 * status:  assigned => needs_review


Comment:

 I used slf4j and logback. The latter is a really clean and well documented
 re-implementation
 of log4j1.2, but logback 'speaks' slf4j natively.
 With slf4j the framework can be switched easier.
 And, there are sufficient versions available in wheezy stable.
 Tomcat does not need to be tweeked, i.e. the onionoo.war contains
 everything necessary for logging this way.

 === build.xml ===
 I switched to java 7, but I also introduced a property for the java
 version. So it'll be easy to change.
 I also included a clean task.

 === Vagranfile, INSTALL ... ===
 I added changes necessary to the Vagrantfile.
 And, I kept all the changes from #12934 .

 === logging configuration ===
  * standalone: logback.xml needs to reside in the classpath (there is a
 copy statement in the {{{run}}} task now.)
  * war: The onionoo.war contains its own logback.xml

 The to logback.xml configurations differ mostly in their logging paths.

 Well, I surely forgot something ;-)

 Patch attached, please review.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12882#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs