[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9874 [BridgeDB]: Research/design a way to automate testing of BridgeDB's HTTPS and email distributors

#9874: Research/design a way to automate testing of BridgeDB's HTTPS and email
distributors
-------------------------+-------------------------------------------------
     Reporter:  isis     |      Owner:  isis
         Type:           |     Status:  closed
  enhancement            |  Milestone:
     Priority:  normal   |    Version:
    Component:           |   Keywords:  bridgedb-unittests, automation, ci,
  BridgeDB               |  bridgedb-gsoc-application, bridgedb-0.2.4
   Resolution:  fixed    |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------
Changes (by isis):

 * status:  needs_review => closed
 * keywords:  bridgedb-unittests, automation, ci, bridgedb-gsoc-application
     =>
     bridgedb-unittests, automation, ci, bridgedb-gsoc-application,
     bridgedb-0.2.4
 * resolution:   => fixed


Comment:

 Replying to [comment:23 isis]:
 > For the `TESTING_BRIDGEDB` envvar, I'd kind of rather see this done by
 testing for a running PID,
 [https://gitweb.torproject.org/bridgedb.git/blob/refs/heads/develop:/lib/bridgedb/test/test_bridgedb.py#l83
 as how it's done here] in `lib/bridgedb/test/test_bridgedb.py`.

 Since all this needed was copy/pasting code from one test suite to two
 others, and it was causing so many irrelevant tracebacks in my local test
 runs for other branches I'm testing, that it drove me nuts and
 [https://gitweb.torproject.org/bridgedb.git/commitdiff/1bfb9c5fce4b47bc7990a2565cbb153c991cfeb1
 I went ahead]
 [https://gitweb.torproject.org/bridgedb.git/commitdiff/e4db0215f3282a6d53ba001ef6f75af648cdebbb
 and committed it].

 Sorry for jumping ahead! In retrospect, I probably should have given you
 more time to get everything in your tests just right before I merged
 anything. Sorry again.

 And thanks again, trygve, for all your help on this!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9874#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs