Re: [tor-bugs] #16695 [Tor]: Decouple generating controller events from sending them to controllers

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#16695: Decouple generating controller events  from sending them to controllers
------------------------+---------------------------------------------
     Reporter:  nickm   |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  SponsorS TorCoreTeam201508 blob
Actual Points:          |  Parent ID:  #16764
       Points:          |
------------------------+---------------------------------------------

Comment (by isis):

 Not sure if this is correct in `queue_control_event_string()`:

 {{{
   int activate_event = 1;
   if (! flush_queued_event_pending && in_main_thread()) {
     activate_event = 1;
     flush_queued_event_pending = 1;
   }
 }}}

 Since `activate_event` will always be true. Is this what we want?  (I'm
 actually not entirely sure if you meant to always schedule the event
 because we just got it, but it seems maybe wrong since this also would
 ignore the `in_main_thread()` check.)

 Also, full disclosure: I skipped over reviewing the windows parts of these
 commits.

 The rest looks okay to me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16695#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs