[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #19024 [Core Tor/Tor]: prop224: Refactor rend_data_t so be able to use multiple HS version
#19024: prop224: Refactor rend_data_t so be able to use multiple HS version
-----------------------------+------------------------------------
Reporter: dgoulet | Owner: dgoulet
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs, prop224 | Actual Points:
Parent ID: #17238 | Points: 4
Reviewer: asn | Sponsor: SponsorR-must
-----------------------------+------------------------------------
Comment (by asn):
Replying to [comment:6 dgoulet]:
> Replying to [comment:3 asn]:
> > Replying to [comment:2 dgoulet]:
> > > https://gitlab.com/dgoulet/tor/merge_requests/8
> >
> > I did an initial review here just to keep things rolling.
> >
> > I will do more review here in the future.
>
> Thanks for this. I've addressed your comments. See 3 new commits on top
I pushed to the merge request. In particular, the addition of a new file
for `rend_data_t` stuff.
Great stuff. I did another review on that same merge request. The merge
request has been polluted with various unrelated changes from master, but
hopefully it's still readable.
Code looks good here! I guess the next step here would be testing it with
the current HS system.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19024#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs