[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19720 [Metrics/CollecTor]: CollecTor should be re-configurable without restart

#19720: CollecTor should be re-configurable without restart
-------------------------------+---------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  enhancement        |         Status:  needs_review
 Priority:  High               |      Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  ctip               |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------------

Comment (by karsten):

 Hmm, no, that doesn't fix the tests.  Here's what I get after reverting
 that `Ignore` temp commit:

 {{{
     [junit] Testcase: testBoolValues took 0.513 sec
     [junit] Testcase: testPathValueException took 0.006 sec
     [junit] Testcase: testArrayValueException took 0.001 sec
     [junit] Testcase: testConfigUnreadable took 6.015 sec
     [junit]     FAILED
     [junit] expected:<0> but was:<2>
     [junit] junit.framework.AssertionFailedError: expected:<0> but was:<2>
     [junit]     at
 org.torproject.collector.conf.ConfigurationTest.testConfigUnreadable(ConfigurationTest.java:212)
     [junit]
     [junit] Testcase: testConfiguration took 0 sec
     [junit] Testcase: testIntValueException took 0.001 sec
     [junit] Testcase: testSetWatchableSourceAndLoad took 0.002 sec
     [junit] Testcase: testArrayArrayValueException took 0.001 sec
     [junit] Testcase: testArrayValues took 0.004 sec
     [junit] Testcase: testIntValues took 0.001 sec
     [junit] Testcase: testConfigChange took 6.006 sec
     [junit]     FAILED
     [junit] Update was not called.
     [junit] junit.framework.AssertionFailedError: Update was not called.
     [junit]     at
 org.torproject.collector.conf.ConfigurationTest.testConfigChange(ConfigurationTest.java:188)
     [junit]
     [junit] Testcase: testFileValues took 0.001 sec
     [junit] Testcase: testBoolValueException took 0.001 sec
     [junit] Testcase: testKeyCount took 0.001 sec
     [junit] Testcase: testArrayArrayValues took 0.001 sec
     [junit] Testcase: testUrlValueException took 0.001 sec
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19720#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs