Re: [tor-bugs] #20021 [Core Tor/Tor]: Require ntor-onion-key in microdescriptors, descriptors

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#20021: Require ntor-onion-key in microdescriptors, descriptors
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:  .1
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by teor):

 For the record, #19163 already rejects nodes that can't do ntor, but after
 parsing and descriptor downloads:

 a76d528 Clients no longer download descriptors for relays without ntor

 {{{
 +  if (rs->version_known && !rs->version_supports_extend2_cells) {
 +    /* We'd ignore it because it doesn't support ntor. */
 +    return 0;
 +  }
 }}}

 579a80d Clients avoid choosing nodes that can't do ntor

     If we know a node's version, and it can't do ntor, consider it not
 running.
     If we have a node's descriptor, and it doesn't have a valid ntor key,
     consider it not running.

 {{{
 +    /* Don't choose nodes if we are certain they can't do ntor */
 +    if (node->rs && !routerstatus_version_supports_ntor(node->rs, 1))
 +      continue;
 +    if ((node->ri || node->md) && !node_has_curve25519_onion_key(node))
 +      continue;
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20021#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs