[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #22618 [Applications/Tor Browser]: Downloading pdf file via file:/// is stalling if the external helper dialog is enabled
#22618: Downloading pdf file via file:/// is stalling if the external helper dialog
is enabled
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-7.0-issues, tbb-regression, | Actual Points:
tbb-e10s, TorBrowserTeam201708 |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):
* keywords: tbb-7.0-issues, tbb-regression, tbb-e10s,
TorBrowserTeam201708R => tbb-7.0-issues, tbb-regression, tbb-e10s,
TorBrowserTeam201708
* status: needs_review => needs_revision
Comment:
Alright, I think I am done with testing and code review. Very nice work!
Here are some nits which should be fixed:
in the torbutton patch:
1) not sure what "may be opened by another or application" means to be
honest.
in the tor browser patch:
2) `nsExternalLoadURIHandler(nsIInterfaceRequestor * aWindowContext,` ->
`nsExternalLoadURIHandler(nsIInterfaceRequestor *aWindowContext,`
3) `// if we are not supposed to ask` <- s/if/If/ (I know it was just
copied and pasted, but...)
4)
{{{
+ // Break our reference cycle with the download warning dialog (set up
in
+ // OnStartRequest)
}}}
missing "." at the end of the sentence (twice)
5) Could you add all the bugs that get fixed by this patch in the commit
message of the follow-up bugfix? (and then doing a `git commit --squash`
or something similar so that this information gets preserved during
rebasing)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22618#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs