[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #24056 [Applications/Tor Browser]: UI locale is detectable by button width
#24056: UI locale is detectable by button width
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: defect | Status:
| needs_review
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Major | Resolution:
Keywords: tbb-fingerprinting, | Actual Points:
TorBrowserTeam201808R |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):
* keywords: tbb-fingerprinting, TorBrowserTeam201808 => tbb-
fingerprinting, TorBrowserTeam201808R
* status: needs_revision => needs_review
Comment:
Replying to [comment:4 pospeselr]:
Thanks for the review!
> Looking at the code, there doesn't *seem* to be any reason why
gPropertiesFile can't be:
> {{{
> static const char* gPropertiesFile[nsContentUtils::PropertiesFile[COUNT]
> }}}
>
> The CreateBundle method each of those strings is passed to expects a
const char* with no hard-coded expectation of length. It's static so the
symbol can't be resolved outside this cpp.
Good point. Following your suggestion I changed the line to
{{{
static const char* gPropertiesFiles[nsContentUtils::PropertiesFile_COUNT]
= {
}}}
> Why is the setting to enable 2 rather than 1?
From [https://dxr.mozilla.org/mozilla-
esr60/rev/dd52b41d2b775e5c7261ce52795268b7670635fc/browser/app/profile/firefox.js#585
firefox.js]:
{{{
// If Accept-Language should be spoofed by en-US
// 0 - will prompt
// 1 - don't spoof
// 2 - spoof
pref("privacy.spoof_english", 0);
}}}
> Apart from that it looks fine to me.
Here's the revised patch:
https://github.com/arthuredelstein/tor-browser/commit/24056+1
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24056#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs