[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31088 [Core Tor/Tor]: Check IPv4 and IPv6 private addresses in descriptors, first hops, and extends
#31088: Check IPv4 and IPv6 private addresses in descriptors, first hops, and
extends
-------------------------------------------------+-------------------------
Reporter: teor | Owner: neel
Type: defect | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| unspecified
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: ipv6, tor-relay, tor-client, tor- | Actual Points:
dirauth |
Parent ID: #24403 | Points:
Reviewer: nickm | Sponsor:
-------------------------------------------------+-------------------------
Changes (by neel):
* status: needs_revision => needs_review
Comment:
A test for `dirserv_router_has_valid_address()` has been implemented.
However, `dirserv_router_has_valid_address()` does not mark null IPv6 as
internal as relays may not have IPv6 addresses.
An internal IPv6 address in `dirserv_router_has_valid_address()` logic is
when it passes `tor_addr_is_internal()` and isn't null (so we don't flag
IPv4-only relays as internal).
A `circuit_extend()` test would not be trivial because it would involve
circuit extending logic, but this is tested in the chutney tests.
`circuit_extend()` is only called in
`connection_edge_process_relay_cell()` on these use cases:
{{{
case RELAY_COMMAND_EXTEND:
case RELAY_COMMAND_EXTEND2:
}}}
And I did not see these be tested outside of chutney.
Setting as needs review.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31088#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs