[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30914 [Core Tor/Tor]: Move struct manipulation code out of confparse.c

#30914: Move struct manipulation code out of confparse.c
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  1
Parent ID:  #29211        |         Points:  1
 Reviewer:  teor          |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 This branch and the general design seem ok to me.
 Thanks for cleaning it up!

 It would be helpful to have a diagram showing the ideal state, and where
 we are in the refactor.

 There is a bit of boilerplate, but there seems to be less boilerplate as
 we go along. It's starting to feel a bit like trunnel. Not sure if code
 generation would help here, or later in the process.

 I left a few minor questions on the PR, feel free to fix them and then get
 someone else to merge. Or leave them and fix them later.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30914#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs