[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4637 [Tor Client]: Two coverity deadcode issues

#4637: Two coverity deadcode issues
------------------------+---------------------------------------------------
 Reporter:  Sebastian   |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by mikeperry):

 I just looked at cid 433 commit. Interesting. What makes coverity think
 this is dead code? If for some reason the Guard flag assignment code
 choses not to assign any Guard flags to Exits, then we would have divide
 by zero errors here, and crash upon consensus formation.

 Maybe coverity realized that it was impossible for us to do that with the
 current Guard assignment algorithm, but it is possible we might decide to
 do it in the future. Guard+Exit does put quite a TCP socket load on fast
 nodes...

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4637#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs