[tor-bugs] #17876 [Tor]: Connection_ap_about_to_close should call connection_edge_about_to_close.

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#17876: Connection_ap_about_to_close should call connection_edge_about_to_close.
---------------------------+--------------------------------
     Reporter:  nickm      |      Owner:
         Type:  defect     |     Status:  new
     Priority:  Very High  |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor        |    Version:
     Severity:  Normal     |   Keywords:
Actual Points:             |  Parent ID:
       Points:             |    Sponsor:
---------------------------+--------------------------------
 In a2ad31a92, we split connection_about_to_close into separate functions.
 And we made connection_edge_about_to_close hold the common logic for
 AP_CONN and EXIT_CONN.  But... we never made connection_ap_about_to_close
 call connection_edge_about_to_close!

 This should be harmless in 0.2.7 and earlier, since all
 connection_edge_about_to_close does is (possibly) generate a warning.  But
 In 0.2.8 for #17590,  we shoved a bunch of code in
 connection_edge_about_to_close that really does matter, for entry
 connections that are pending circuits.

 Bug in 0.2.3.2-alpha.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17876>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs