Re: [tor-bugs] #20546 [Metrics/CollecTor]: implement CleanUtils

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#20546: implement CleanUtils
-------------------------------+---------------------------
 Reporter:  iwakeh             |          Owner:  aegis2501
     Type:  enhancement        |         Status:  assigned
 Priority:  Medium             |      Milestone:
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  metrics-help       |  Actual Points:
Parent ID:  #20518             |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------

Comment (by iwakeh):

 Cool!

 I didn't look deeply, e.i. think my way through the code, yet, but it's a
 very clean style.
 Your test coverage is also up to 93% for CleanUtils, great.  (I didn't
 reply to your question
 in comment:6, because trac doesn't mail anything for edited comments.  So
 I didn't see the question.)

 Maybe, try to think up some tests that trigger exceptions and also to find
 out, what happens when unexpected input is given, like `null` or empty
 Strings or a file disappeared before being erased or never existed etc.

 And, we also have a Checkstyle and task `ant checks`, which currently
 complains a little about CleanUtils and CleanUtilsTest.  Nothing dramatic,
 mostly indentation and spacing.
 Could you get that to pass again?

 Thanks a lot for that work!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20546#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs