[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #24337 [Core Tor/Tor]: Every _free() function should be a macro that sets the corresponding pointer to NULL.
#24337: Every _free() function should be a macro that sets the corresponding
pointer to NULL.
-----------------------------+------------------------------------
Reporter: nickm | Owner: nickm
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: review-group-26 | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor: Sponsor8-can
-----------------------------+------------------------------------
Changes (by nickm):
* status: needs_revision => needs_review
Comment:
I've made a new branch based on the old one. It removes the uppercasing
commits. It also adds a new pair of commits that change tor_free() and
object_free() so that they can withstand usage like `tor_free(ptr++);`.
The branch is now `macro_free_v2`. The only new commits are
d6549f0d1d68e09d260968af95016218ae16072d and
534e6094fc5336785105deeaacd487e9e79ebbab (and the revised changes file).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24337#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs