Re: [tor-bugs] #23459 [Core Tor/Tor]: prop224: Specialize interface of hs_circuitmap_get_rend_circ_client_side()

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#23459: prop224: Specialize interface of hs_circuitmap_get_rend_circ_client_side()
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, prop224-extra,              |  Actual Points:
  refactoring, easy, 032-unreached               |
Parent ID:                                       |         Points:  0.4
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by asn):

 Great! Two more nitpicks:

 - `make check-spaces` complains about a wide line (more than 80 columns)
 in `hs_client.c:943`. Split that into two lines as follows:
 {{{
   rend_circ =
 hs_circuitmap_get_established_rend_circ_client_side(rendezvous_cookie);
 }}}

 - Add a period to the end of your changes file as follows: `Closes ticket
 23459.`

 Do the above changes on a small fixup commit, push it and I'll mark the
 ticket as `merge_ready`.

 Thanks! :-)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23459#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs