[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24423 [Core Tor/Tor]: Fix STACK warnings in Tor

#24423: Fix STACK warnings in Tor
-----------------------------+------------------------------------
 Reporter:  nickm            |          Owner:  nickm
     Type:  defect           |         Status:  accepted
 Priority:  Medium           |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  review-group-27  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  catalyst         |        Sponsor:
-----------------------------+------------------------------------

Comment (by catalyst):

 Hm maybe that should be `if (cert_lifetime <= min_real_lifetime +
 start_granularity || cert_lifetime > now)` because the subtraction for
 `earliest_start_time` could still underflow.  (also fixed the comparison
 operator that I had wrong before)

 Then again you could also start getting mixed signed/unsigned comparison
 warnings so maybe we need to use a signed intermediate.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24423#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs