[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files
#21377: DirAuths should expose bwauth bandwidth files
-------------------------------------------------+-------------------------
Reporter: tom | Owner: juga
Type: enhancement | Status:
| needs_revision
Priority: High | Milestone: Tor:
| 0.4.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-dirauth, metrics, tor-bwauth, | Actual Points:
035-removed-20180711, 040-roadmap-proposed |
Parent ID: #25925 | Points:
Reviewer: ahf | Sponsor:
-------------------------------------------------+-------------------------
Comment (by teor):
Replying to [comment:35 juga]:
> Replying to [comment:34 teor]:
> > > * Should we be passing "len" to write_http_response_header when
compression is in use? I'm not sure what is correct here.
> >
> > If it is present, Content-Length must be the length of the encoded
data.
> >
> > > Maybe we're supposed to send the compressed length if compression is
in use?
> >
> > When we deliver compressed replies in other code, we don't provide
Content-Length:
> >
https://github.com/torproject/tor/blob/8020d6fb05d9477e77c6ca554dc1288873f6115c/src/feature/dircache/dircache.c#L1293
>
> I verified that there's not Content-Length in the header doing that.
I don't understand what you mean.
If you pass a zero or positive length, then the code sets Content-Length.
I added a suggested fix on the pull request.
> If i call detect_compression_method, as
test_dir_handle_get_status_vote_current_consensus_ns is doing:
https://github.com/torproject/tor/blob/8020d6fb05d9477e77c6ca554dc1288873f6115c/src/test/test_dir_handle_get.c#L1875,
it will say the compression method is UNKNOWN_METHOD, instead of
ZLIB_METHOD. What i'm doing wroing?
I don't understand what you mean here.
If you're calling the new code in the test, you have to add headers to the
request.
Otherwise, the new code should return NO_METHOD.
I don't understand how you are getting UNKNOWN_METHOD.
Please show me the code you are using, and the logs of the results.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21377#comment:36>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs