[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28458 [Core Tor/sbws]: Stop resolving domains locally and check same flags for the 2nd hop

#28458: Stop resolving domains locally and check same flags for the 2nd hop
------------------------------------------+--------------------------------
 Reporter:  juga                          |          Owner:  juga
     Type:  defect                        |         Status:  merge_ready
 Priority:  Medium                        |      Milestone:  sbws:
                                          |  1.0.x-final
Component:  Core Tor/sbws                 |        Version:  sbws: 1.0.0
 Severity:  Normal                        |     Resolution:
 Keywords:  sbws-1.0-must-moved-20181128  |  Actual Points:
Parent ID:                                |         Points:
 Reviewer:  pastly                        |        Sponsor:
------------------------------------------+--------------------------------
Changes (by pastly):

 * status:  needs_review => merge_ready


Comment:

 LGTM.

 Recommendations:

 - remove `Relay.can_exit_to(...)` after verifying it will be unused upon
 applying this patch.
 - remove `resolve(...)` after verifying it will be unused upon applying
 this patch.

 Your choice on whether to act on those recommendations. merge_ready if you
 decide to not act.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28458#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs