Re: [tor-bugs] #26843 [Applications/Tor Browser]: TBA: Investigate how Mozilla Fennec provides localization

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#26843: TBA: Investigate how Mozilla Fennec provides localization
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, TBA-a2,                  |  Actual Points:
  GeorgKoppen201811, TorBrowserTeam201812        |
Parent ID:  #26782                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:19 boklm]:
 > Replying to [comment:17 gk]:
 > > Okay, I have an updated branch for review, `bug_26843_v6`
 (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_26843_v6&id=1313336490abb4773e20d40347db79e46c26727e).
 > >
 > > Compared to `bug_26843_v5` it is rebased on the latest `master` and
 contains an indication in the bundle name that the .apk is actually not a
 single-locale one, using "multi" as Mozilla does.
 >
 > It seems that when we are running `AB_CD=multi ./mach package`, the
 variable `MOZ_CHROME_MULTILOCALE` contains all the locales we want.
 However, when we run `./mach build chrome-[% lang %]`, only the current
 and previous locales are included in `MOZ_CHROME_MULTILOCALE`. Is `./mach
 build chrome-[% lang %]` ignoring the variable `MOZ_CHROME_MULTILOCALE`
 (and in this case it doesn't matter if it doesn't contain all the
 locales), or should we add all the locales before running the first
 `./mach build chrome-[% lang %]`?

 Yeah, `./mach build` is ignoring it. But `./mach package` needs it. I used
 the `FOREACH` loop to populate the env variable while cycling through the
 locales anyway.

 > We could use this line to set all the locales in
 `MOZ_CHROME_MULTILOCALE`:
 > {{{
 > export MOZ_CHROME_MULTILOCALE='[% tmpl(c('var/locales').join(' ')) %]'
 > }}}

 That's probably better, yes. I'll take that approach instead of my clumsy
 one.

 > An other minor thing: I think it would be better to extract the locales
 in a sub-directory (such as `/var/tmp/dist/locales`) instead of directly
 in `/var/tmp/dist`.

 Okay, fine with me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26843#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs