[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28697 [Applications/Tor Browser]: Our QA and testing .apks are signed with a key per build



#28697: Our QA and testing .apks are signed with a key per build
----------------------------------------------+----------------------------
 Reporter:  gk                                |          Owner:  tbb-team
     Type:  defect                            |         Status:
                                              |  needs_revision
 Priority:  Medium                            |      Milestone:
Component:  Applications/Tor Browser          |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201812  |  Actual Points:
Parent ID:  #25164                            |         Points:
 Reviewer:                                    |        Sponsor:
----------------------------------------------+----------------------------

Comment (by boklm):

 Replying to [comment:6 gk]:
 > {{{
 > -
 > +mv $rootdir/[% c('input_files_by_name/keystore') %] .
 > +
 > }}}
 > contains a trailing whitespace at the end of the last line. Please
 remove that one.

 Do we really need to move `android-qa.keystore` to the current directory,
 or could we just use `-keystore $rootdir/android-qa.keystore` instead of
 `-keystore android-qa.keystore` in the `jarsigner` command?

 For the `how-to-generate-keystore` file:
  - maybe this could be renamed to `how-to-generate-keystore.txt`
  - we can add a `:` after `type the following command`
  - we can add a comment pointing to this file in `projects/tor-
 browser/config` near `android-qa.keystore`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28697#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs