[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28738 [Core Tor/sbws]: Stop merging multiple torrc options with the same name
#28738: Stop merging multiple torrc options with the same name
---------------------------+-----------------------------------
Reporter: teor | Owner: (none)
Type: defect | Status: new
Priority: Medium | Milestone: sbws: 1.0.x-final
Component: Core Tor/sbws | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
---------------------------+-----------------------------------
Comment (by juga):
Replying to [comment:8 teor]:
[..]
> > Even if only stem.py uses these options, i think they should be in
globals.py, since we might need to change them and globals.py should be
the place where to change sbws defaults.
>
> Let's leave any refactoring until #28737.
This would not change any functionality, but ok.
[...]
> Why write a parser, when tor will parse lines for us?
There's not any way to pass torrc options to stem using torrc syntax, only
dictionaries.
> Option 4 is #28737, and it should work reasonably well. But it's a new
feature, so it belongs in sbws 1.1.
If i understand correctly this ticket, all the options would be in the
form of dictionaries?
> Here's another option:
>
> 5. Fix sbws' current tor option parsing code:
> * allow options with no argument (#28715)
> * stop trying to merge sbws options with the same name (#28738), until
we refactor in sbws 1.1 (#28737)
And not support "extra_lines" until 1.1?.
I only need them for the test network. Do we have reasons why operators
might need them?.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28738#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs