[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28142 [Core Tor/Tor]: Merge original WTF-PAD branch
#28142: Merge original WTF-PAD branch
-------------------------------------------------+-------------------------
Reporter: asn | Owner:
| mikeperry
Type: enhancement | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: wtf-pad, tor-relay, tor-cell, | Actual Points:
padding |
Parent ID: #28631 | Points:
Reviewer: asn | Sponsor:
| Sponsor2
-------------------------------------------------+-------------------------
Comment (by mikeperry):
Ok I fixed the errors in PR 574. They were due to return type mismatched,
which caused clang to garble the return value of
circpad_histogram_usec_to_bin(). This is now running as
https://github.com/torproject/tor/pull/575
If you fix your unit tests, please rebase your stuff on top of PR575, or
vice-versa?
As I said on IRC, note that https://github.com/torproject/tor/pull/461
still has some fixup comments from nickm that are currently hidden due to
being "outdated" (I think we just changed code near them). They still need
fixups tho. I also commented on a couple things in that PR.
After fixups, I think next steps for implementation is making a working
machine. See my thoughts in
https://trac.torproject.org/projects/tor/ticket/28634#comment:3. You can
work on that if you like, after fixups. I can go back to working on tests,
since you are tired of that.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28142#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs