[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

#21377: DirAuths should expose bwauth bandwidth files
-------------------------------------------------+-------------------------
 Reporter:  tom                                  |          Owner:  juga
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,    |  Actual Points:
  035-removed-20180711, 040-roadmap-proposed     |
Parent ID:  #25925                               |         Points:
 Reviewer:  ahf                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 It looks like you're setting the compression state, then adding the data
 uncompressed.

 You didn't open a pull request, so I commented on the commit:
 https://github.com/torproject/tor/commit/b03091842bc4590e11e3ac026daae8ed6d8f7554#r31629291
 https://github.com/torproject/tor/commit/b03091842bc4590e11e3ac026daae8ed6d8f7554#r31629096

 I also opened:
 * #28815 to clean up the copied code,
 * #28816 to log a bug warning when uncompressed data is added to a
 compressed connection
 You don't have to do these tickets: they are not on the roadmap.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21377#comment:42>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs